Skip to content

Insert improperly compares number of columns and value columns #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Insert improperly compares number of columns and value columns #27

wants to merge 1 commit into from

Conversation

balint-balku-scraperapi
Copy link

Insert performs an improper check when multiple columns and multiple rows of data passed to the call.

Example:

insert('table_name',
  [ 'column1', 'column2' ],
  [ [ 'row1_col1', 'row1_col2' ], [ 'row2_col1', 'row2_col2' ], [ 'row3_col1', 'row3_col2' ] ]
);

The above should be ok as the number of columns matches the number of value-columns, but it does throw an error in the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@balint-balku-scraperapi